Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base apr for myswap #46

Closed
wants to merge 15 commits into from
Closed

Conversation

fishonamos
Copy link
Contributor

@fishonamos fishonamos commented Jun 5, 2024

PR Fixes:

  • Added a base apr for MySwap

Resolves [#1]

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

src/store/myswap.store.ts Show resolved Hide resolved
src/store/myswap.store.ts Outdated Show resolved Hide resolved
src/store/myswap.store.ts Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Jun 19, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10294468 Triggered Generic High Entropy Secret 8be4a30 next.config.mjs View secret
10294468 Triggered Generic High Entropy Secret 8be4a30 next.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@fishonamos
Copy link
Contributor Author

fishonamos commented Jun 22, 2024

I want to close this in favour of #52 @akiraonstarknet

akiraonstarknet added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants