Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SEO Optimization and Carousel addition #61

Merged
merged 13 commits into from
Jul 15, 2024
Merged

feat: SEO Optimization and Carousel addition #61

merged 13 commits into from
Jul 15, 2024

Conversation

hemantwasthere
Copy link
Contributor

Resolves #56

Vercel website link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
  • My PR passes all checks (build, lint, formatting, etc)

Copy link

gitguardian bot commented Jul 7, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10294468 Triggered Generic High Entropy Secret 2aa0492 next.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@akiraonstarknet
Copy link
Contributor

  1. You think need to configure a dynamic metadata info for strategy page too (based on strategy title, APY and description)
  2. Will arrange mobile friendly images, u can config images for mobile (carousal ones)

@hemantwasthere

@akiraonstarknet akiraonstarknet merged commit ff2aee8 into strkfarm:dev Jul 15, 2024
0 of 2 checks passed
akiraonstarknet added a commit that referenced this pull request Sep 20, 2024
Community page [Coming soon]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants