Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Carmine Pools #88

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Added the Carmine Pools #88

merged 11 commits into from
Aug 6, 2024

Conversation

Dprof-in-tech
Copy link
Contributor

PR Fixes:

  • 1 Made sure my code is optimized an everything works
  • 2 integrated the carmine options AMM so that we can track the carmine pools
    Screenshot from 2024-07-30 06-57-49
    Screenshot from 2024-07-30 06-57-40
    Screenshot from 2024-07-30 06-57-26

Resolves #47

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
  • My PR passes all checks (build, lint, formatting, etc)

Copy link

gitguardian bot commented Jul 30, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10294468 Triggered Generic High Entropy Secret 2ac0d93 src/app/slinks/template.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@akiraonstarknet akiraonstarknet merged commit 0edd546 into strkfarm:dev Aug 6, 2024
0 of 2 checks passed
@akiraonstarknet
Copy link
Contributor

@all-contributors please add @Dprof-in-tech for code

Copy link
Contributor

@akiraonstarknet

I've put up a pull request to add @Dprof-in-tech! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Carmine option pools
2 participants