Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-1475: Change ArtifactEntry properties date types into datetime #16

Merged
merged 9 commits into from
Oct 10, 2019
Merged

Issue-1475: Change ArtifactEntry properties date types into datetime #16

merged 9 commits into from
Oct 10, 2019

Conversation

evsikov
Copy link
Contributor

@evsikov evsikov commented Oct 6, 2019 •
edited by carlspring
Loading

Fixes for strongbox/strongbox#1475.

Changed ArtifactEntry properties:

  • created
  • lastUsed
  • lastUpdated
    from type date to type datetime.

@ghost
Copy link

ghost commented Oct 6, 2019 •
edited by ghost
Loading

DeepCode Report (#9fab6e)

DeepCode analyzed this pull request.
There are no new issues.

@evsikov evsikov mentioned this pull request Oct 6, 2019
Closed
8 tasks
@evsikov evsikov changed the title SB-1475: new migration. Change ArtifactEntry.created property type into 'datetime' SB-1475: new migration. Change ArtifactEntry properties 'date' types into 'datetime' Oct 6, 2019
@evsikov evsikov mentioned this pull request Oct 6, 2019
Merged
10 tasks
@sbespalov
Copy link
Member

@evsikov this new changeset looks fantastic! thank you very much for your efforts improving it!

@steve-todorov @fuss86 I've checked OrientDB statements on my local DB instance (with lot of data) and it seems works as expected, so we probably can proceed and merge it.

fuss86
fuss86 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@fuss86 fuss86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :) LGTM

@carlspring carlspring merged commit d67e007 into strongbox:master Oct 10, 2019
@carlspring carlspring changed the title SB-1475: new migration. Change ArtifactEntry properties 'date' types into 'datetime' Issue-1475: Change ArtifactEntry properties date types into datetime Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuss86 fuss86 fuss86 approved these changes

@sbespalov sbespalov sbespalov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evsikov @sbespalov @fuss86 @carlspring