-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Strongbox from OrientDB to JanusGraph #19
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
db: | ||
janus-graph: | ||
storage-username: cassandra | ||
storage-password: cassandra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been thinking that we need to make these passwords randomly generated upon first boot so that one can safely use Strongbox in production. Could you please add a // TODO: [First start] randomize
here and before any other similar field(s) you come across? This will need to be planned as a separate follow-up task. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have the default user/pass for this set to admin/password
, as we're using this convention across the codebase already and we'll need to have a follow-up task to generate a password for this at the first boot. If we have different initial (default) credentials, it will make things more confusing (and we'll have to remember these).
04751ad
to
52cb59d
Compare
52cb59d
to
2f42188
Compare
c86ef8e
to
e08b500
Compare
Closes #1649.