Incremental Janusgraph schema updates #1588 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbespalov
changed the title
sbespalov
changed the title
sbespalov
requested review from
steve-todorov and
carlspring
and removed request for
steve-todorov
carlspring
reviewed
Aug 18, 2020
README.md
Outdated
|
|
||
| ## How to build this project ? | ||
| To build the code, simply execute: | ||
| `mvn clean install` | ||
|
|
||
| ## What's the result of the build process ? | ||
| This project produces the following artifacts: | ||
| * `strongbox-db-liquibase-${version}.jar` : Located in `strongbox-db-liquibase/target`, which contains current database liquibase changesets | ||
| * `strongbox-db-shcema-${version}.jar` : Located in `strongbox-db-schema/target`, which contains current database changesets |
There was a problem hiding this comment.
Suggested change
| * `strongbox-db-shcema-${version}.jar` : Located in `strongbox-db-schema/target`, which contains current database changesets | |
| * `strongbox-db-schema-${version}.jar` : Located in `strongbox-db-schema/target`, which contains current database changesets |
carlspring
reviewed
Aug 18, 2020
README.md
Outdated
| * `strongbox-db-import` which creates a `zip` file with packed built database snapshot built from the liquibase changesets | ||
|
|
||
| ## How is this project used in [strongbox](https://github.com/strongbox/strongbox) ? | ||
| [strongbox](https://github.com/strongbox/strongbox) uses this project submodules as required dependencies. During the startup of [Strongbox](https://github.com/strongbox/strongbox), the application detects if an OrientDB database already exists. If not, then the application uses an extracted empty OrientDB database snapshot from the `strongbox-db-import` artifact. If the OrientDB database already exists, then the application applies all missing liquibase changesets from the `strongbox-db-liquibase` artifact. | ||
| [strongbox](https://github.com/strongbox/strongbox) uses this project submodules as required dependencies. During the startup of [Strongbox](https://github.com/strongbox/strongbox), the application detects if an JanusGraph database already exists. If not, then the application uses an extracted empty JanusGraph database snapshot from the `strongbox-db-import` artifact. If the JanusGraph database already exists, then the application applies all missing changesets from the `strongbox-db-schema` artifact. |
There was a problem hiding this comment.
Suggested change
| [strongbox](https://github.com/strongbox/strongbox) uses this project submodules as required dependencies. During the startup of [Strongbox](https://github.com/strongbox/strongbox), the application detects if an JanusGraph database already exists. If not, then the application uses an extracted empty JanusGraph database snapshot from the `strongbox-db-import` artifact. If the JanusGraph database already exists, then the application applies all missing changesets from the `strongbox-db-schema` artifact. | |
| [strongbox](https://github.com/strongbox/strongbox) uses this project submodules as required dependencies. During the startup of [Strongbox](https://github.com/strongbox/strongbox), the application detects if a JanusGraph database already exists. If one doesn't exist, it uses an extracted empty JanusGraph database snapshot from the `strongbox-db-import` artifact; if a database exists, then the application applies all missing changesets from the `strongbox-db-schema` artifact. |
carlspring
reviewed
Aug 18, 2020
strongbox-db-import/src/main/java/org/carlspring/strongbox/dbimport/Application.java
Outdated
Show resolved
Hide resolved
carlspring
reviewed
Aug 18, 2020
| /** | ||
| * @author ankit.tomar | ||
| */ | ||
| public interface Properties |
There was a problem hiding this comment.
Why are all these constants in an interface? A lot of them are layout provider-specific. Wouldn't it be better to have at least part of them in the respective modules, under a package like org.carlspring.strongbox.db.properties and then have a class like, for example, Maven2LayoutProviderProperties?
What do you think, @sbespalov , @anki2189 , @steve-todorov ?
There was a problem hiding this comment.
@carlspring by "respective modules" you mean strongbox-storage-layout-providers modules?
There was a problem hiding this comment.
Yeah, the layout providers and perhaps (in the future) other modules as well.
There was a problem hiding this comment.
this is not possible, we couldn't access anything within strongbox-storage-layout-providers modules from strongbox-db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1588