Related to Issue 1005 in Strongbox: Addition of checkSumsMap property to liquibase

[ogryniuk]

Added an xml file with the details of a new property

[carlspring]

Is there any actual code in this pull request? The file seems to be empty.

Also, checksum is one word, so could you please make sure the property is named correctly (checksumsMap)? Thanks!

[sbespalov]

the type should be embeddedmap as follows:

type="embeddedmap" linkedType="String"

[sbespalov]

@ogryniuk can you please also provide a screenshot from OrientDB Studio with ArtifactEntry schema?
This needed to be sure that changeset correctly applied and mapped into OreintDB native schema.
By default you can access OrientDB Studio with http://localhost:2480/studio/index.html.

[ogryniuk]

@ogryniuk can you please also provide a screenshot ...?

@sbespalov I understand why we must have a screenshot but would need an advice.

If I am right, OrientDb starts from a strongbox snapshot (at least, it is the way I started it recently).

But snapshot is a tested working version of the project published on GitHub and my changes to the liquibase would evidently be absent from it. They would only be on my machine and nowhere else.

So, how may I proceed in this situation?

[sbespalov]

But snapshot is a tested working version of the project published on GitHub and my changes to the liquibase would evidently be absent from it.

this is not required, you only need to have your strongbox-db snapshot version installed into your local .m2 repository. So just strongbox-db$ mvn clean install should be enough.

[ogryniuk]

just strongbox-db$ mvn clean install should be enough.

@sbespalov I tried it but the browser did not load anything. Any ideas about what to do? I already looked into Firewall and Proxy settings, saw nothing unusual. Also had set to true an environment variable STRONGBOX_ORIENTDB_STUDIO_ENABLED, again with no result.

[sbespalov]

Can you join our rocket chat? So we can manage it there пт, 15 мар. 2019 г., 18:15 ogryniuk <[email protected]>:

…

just strongbox-db$ mvn clean install should be enough. @sbespalov <https://github.com/sbespalov> I tried it but the browser did not load anything. Any ideas about what to do? I already looked into Firewall and Proxy settings, saw nothing unusual. Also had set to true an environment variable STRONGBOX_ORIENTDB_STUDIO_ENABLED, again with no result. [image: Opera Snapshot_2019-03-15_123125_localhost] <https://user-images.githubusercontent.com/18189414/54426736-3cbca680-4721-11e9-8f5b-7e11d5e16a10.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVunQ09fMe1FDK_PSLbtzJQ2ZTzZl_Daks5vW4DQgaJpZM4boJEk> .

[ogryniuk]

Can you join our rocket chat?

@sbespalov Sure

[ogryniuk]

@sbespalov

Here is the snapshot of ArtifactEntry schema

[carlspring]

As discussed previously, this should be checksums, not checkSums. (Could you also please change this in the ArtifactEntry class?).

Also, as author, could you please use the system id that we're using -- [email protected]? Thanks! :)

[ogryniuk]

Good evening @carlspring ,
First I changed the variable name the way you asked but then looked at OrientDB schema for this entity (ArtifactEntry) and saw that all the properties in fact follow the naming convention checkSums (not checksums). See the snapshot attached above.

Thus, do not you think it is better to rename it back to checkSums?

[carlspring]

If this is the case, then you've spotted something that needs to be corrected. Could you please changes those to checksums as well? Thanks!

[fuss86]

@ogryniuk I believe you see the database state from the moment when you initially used checkSums word instead of checksums. If you drop db directory from the strongbox-web-core, install strongbox-db with checksums, and then restart the strongbox app I believe the database will be setup using proper field naming.

[ogryniuk]

If this is the case, then you've spotted something that needs to be corrected. Could you please changes those to checksums as well?

@carlspring I would need a clarification to be sure I will do what you wish. So, you would like that I remove capitalisation from all the properties in ArtifactEntry xml?

For each of the following properties: storageId, repositoryId, artifactCoordinates, tagSet. artifactPath, sizeInBytes, downloadCount, lastUpdatedlastUsed?

Is it so? Please confirm

[carlspring]

@ogryniuk ,

We are not talking about the decapitalization of everything. Checksum is one word, therefore it should not be checkSums. Please, follow @fuss86 advice! Thanks! :)

[ogryniuk]

@carlspring
In such case, know that it is already renamed checksums, as you can see it in the updated snapshot

[carlspring]

Okay, thanks for changing it! :)

[carlspring]

@ogryniuk ,

What's the status of this task?

[ogryniuk]

@carlspring
The status is that it is done (since 9 days).
However, as it is up to you to accept it or not: As you know, this pull request is dependent on other changes which are still pending - there are still tests to be done for the addition of a checksum and I keep looking for a way to do them.

[carlspring]

@ogryniuk ,

Thanks for the update! We require tests when code is changed, or added.

@sbespalov , @fuss86 : Could you please give @ogryniuk some hints / links on how to implement some tests for this? Thanks!

[ogryniuk]

Closed in favour of #10