Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy version upgrade for JG branch #135

Open
wants to merge 31 commits into
base: issues/1649
Choose a base branch
from

Conversation

anki2189
Copy link
Member

@anki2189 anki2189 commented Dec 10, 2020

Pull Request Description

This pull request closes strongbox/strongbox#1705, #1854

Acceptance Test

  • Building the code of the strongbox-parent with mvn clean install still works.
  • Building the code of the strongbox project with mvn clean install -Dintegration.tests still works.
  • Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
  • Building the code and running the strongbox-distribution from a zip or tar.gz still works.
  • The tests in the strongbox-web-integration-tests still run properly.

Questions

  • Does this pull request break backward compatibility?

    • Yes
    • No
  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No
  • Does this require an update of the documentation?

    • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
    • No

Code Review And Pre-Merge Checklist

  • My code follows the coding convention of this project.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • My changes generate no new warnings.

@carlspring
Copy link
Member

carlspring commented Dec 13, 2020

This pull request needs to be rebased, as it has a lot of noise and has a conflict. Will re-test after the rebase.

AricMonary and others added 26 commits December 14, 2020 13:47
- Upgrade the maven-resources plugin from 3.0.2 to 3.2.0
…JDK 8 (or 11)

Added maven version to error message for easier debugging.
…ch in the strongbox-parent

It seems there is some sort of bug with the `maven-dependency-plugin` that causes a 401 when deploying to the repository through Jenkins. Reverting this to `2.8.2`.
Update the dependency version for commons-beanutils.
Also fix the placement of the comment explaining the beanutils
version override. It was moved upwards above a different
dependency by another commit.

This fixes strongbox/strongbox#1847
@anki2189
Copy link
Member Author

anki2189 commented Dec 14, 2020

This pull request needs to be rebased, as it has a lot of noise and has a conflict. Will re-test after the rebase.

Rebased, not sure why it has commits from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants