Generic settings api #232
Generic settings api #232
Conversation
sjaeckel
force-pushed
the
generic-settings-api
branch
from
320edcf
to
7dbdc2a
Compare
|
@pasis what do you think of this idea? |
sjaeckel
force-pushed
the
generic-settings-api
branch
from
7dbdc2a
to
32f4871
Compare
I like the direction. But JID (and probably password) sounds to me like something more important than just a setting. Not critical, just my preferences. |
Cool! Nice to hear.
I also thought about whether there's some more important things that deserve a separate API and the JID/password was on that list. I ended up putting everything in there, since if you use SASL-EXTERNAL via client certificates to authenticate, there's no JID (or password) required. You could give a JID, if you want to authenticate as a different user than given in the certificate, but that's just an option. |
sjaeckel
force-pushed
the
generic-settings-api
branch
2 times, most recently
from
8f4a9cd
to
0ce84f8
Compare
sjaeckel
force-pushed
the
xep-0138
branch
2 times, most recently
from
0d573b4
to
3f03de0
Compare
sjaeckel
force-pushed
the
generic-settings-api
branch
from
0ce84f8
to
01928af
Compare
|
@singpolyma do you have an opinion on this PR? |
|
feels more or less the same to me. a matter of taste |
Instead of having a multitude of setter API functions for configuration options, provide generic ones for the different types we have. Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
generic-settings-api
branch
from
01928af
to
541c22c
Compare
Introduce generic
xmpp_conn_set_*()APIInstead of having a multitude of setter API functions for configuration options, provide generic ones for the different types we have.