Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts #3370

Open
2 of 12 tasks
hugo-vrijswijk opened this issue Aug 20, 2024 · 3 comments
Open
2 of 12 tasks

Add keyboard shortcuts #3370

hugo-vrijswijk opened this issue Aug 20, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@hugo-vrijswijk
Copy link
Member

hugo-vrijswijk commented Aug 20, 2024

Ideas:

  • Escape: close the drawer if open fix(elements): close drawer when pressing Escape #3371
  • Ctrl K to open a file picker feat(elements): add file picker #3404
  • Left/Right: navigate between previous/next mutant
    • Holding Alt could navigate focus without opening a new mutant
  • Tab: Cycle focus through mutant dots~~ make mutant-dots focusable in the browser
    • This would be the same as Alt + ArrowRight
  • Enter: Open the drawer for the currently focused mutant dot
  • Ctrl 1/Ctrl 2: switch between Mutants/Tests tab
  • Backspace: go up 1 level in the breadcrumb
  • Ctrl + something: switching mutant filters
  • Ctrl + ?: open a shortcut popup showing the shortcuts
    • Having each shortcut in the tooltip would also be good
@xandervedder
Copy link
Contributor

CTRL + K or CTRL + P to open a file picker for easy navigation (like in vscode or any docs site that has it), maybe it could also show per file the mutant count or mutation score.

CTRL + SHIFT + K or CTRL + SHIFT + P could then be used to show all shortcuts and/or execute them.

@vivganes
Copy link
Contributor

In most of the well-known keyboard shortcuts, Ctrl is replaced by Cmd in Mac.

Example: Ctrl+C --> Cmd + C

Not sure if we need to consider switching to Cmd for these shortcuts in Mac environment.

@hugo-vrijswijk
Copy link
Member Author

That would be preferred. There is the metakey property, but that maps to the windows key on Windows. I think for this we would have to check if the user is on mac. Or support either the meta or ctrl key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants