Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements): add file picker #3404

Merged
merged 22 commits into from
Nov 20, 2024
Merged

feat(elements): add file picker #3404

merged 22 commits into from
Nov 20, 2024

Conversation

xandervedder
Copy link
Contributor

@xandervedder xandervedder commented Sep 13, 2024

Adds a file picker to the report, which allows for easier keyboard traversing over the report.

afbeelding

related #3370


ToDo:

  1. When report does not have any test files, it still shows 'all tests" in the picker but it redirects to an empty page.

@xandervedder xandervedder added the enhancement New feature or request label Sep 13, 2024
Copy link

nx-cloud bot commented Sep 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c130092. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=stryker --projects=metrics,elements,real-time -- --incremental
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@xandervedder xandervedder marked this pull request as ready for review September 27, 2024 11:37
@xandervedder
Copy link
Contributor Author

It seems like we cannot update the screenshots anymore due to Nx Cloud:

https://github.com/stryker-mutator/mutation-testing-elements/actions/runs/11070168343/job/30759261813

NX Nx Cloud: Workspace is disabled

@hugo-vrijswijk
Copy link
Member

It seems like we cannot update the screenshots anymore due to Nx Cloud:

https://github.com/stryker-mutator/mutation-testing-elements/actions/runs/11070168343/job/30759261813

NX Nx Cloud: Workspace is disabled

You still can. Nx cloud is IMO not very friendly for open-source projects. Everything still works the same. You can update screenshots by running the workflow action on your branch. You might have to bring your branch up to date with master first

Copy link

bundlemon bot commented Oct 18, 2024

BundleMon (elements)

Files updated (3)
Status Path Size Limits
index.js
255.61KB (+10.68KB +4.36%) -
index.cjs
191.56KB (+9.59KB +5.27%) -
mutation-test-elements.js
211.13KB (+9.47KB +4.7%) -

Total files change +29.75KB +4.73%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@hugo-vrijswijk hugo-vrijswijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with it a little bit, but I think it doesn't fully work as it should yet.

I'm also wondering if you could get nice behaviour by default by using the html dialog element

1: Opening the search icon and pressing Enter right away navigates to the first file, but doesn't dismiss the file picker. Also, I think opening the file-picker should focus the search-box. You can use the property autofocus on the input element for that.

Screen.Recording.2024-11-12.at.12.50.08.mov

2: Navigation doesn't always work with relative url's. Not sure why this works in some reports, but not in others.

Screen.Recording.2024-11-12.at.12.51.58.mov

3: Partial search does not work as expected. Ideally the search would be case-insensitive, too

Screen.Recording.2024-11-12.at.12.54.24.mov

packages/elements/src/components/breadcrumb.ts Outdated Show resolved Hide resolved
@xandervedder xandervedder force-pushed the feature/file-picker branch 2 times, most recently from 551d508 to 5afe75d Compare November 16, 2024 14:00
@xandervedder
Copy link
Contributor Author

Should be fixed now, I tried using the dialog element but it broke too much which is why I dropped it for now.

Copy link
Member

@hugo-vrijswijk hugo-vrijswijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the back-and-forth with review comments. I took a bit of a closer look this time. If everything is resolved I think you can merge this. It's an awesome feature!

I think the dialog should be a separate experiment PR

Copy link
Member

@hugo-vrijswijk hugo-vrijswijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@xandervedder xandervedder merged commit 8310717 into master Nov 20, 2024
7 checks passed
@xandervedder xandervedder deleted the feature/file-picker branch November 20, 2024 21:09
@hugo-vrijswijk hugo-vrijswijk mentioned this pull request Nov 22, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants