Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): preserve whitespace when rendering mutant description and statusReason #2926

Merged
merged 4 commits into from
Dec 23, 2023

Conversation

hugo-vrijswijk
Copy link
Member

@hugo-vrijswijk hugo-vrijswijk commented Dec 21, 2023

Closes half of #2925

Before:

afbeelding

After:

afbeelding

Copy link

bundlemon bot commented Dec 21, 2023

BundleMon (elements)

Files updated (3)
Status Path Size Limits
index.js
266.39KB (+166B +0.06%) -
index.cjs
195.08KB (+105B +0.05%) -
mutation-test-elements.js
195.08KB (+105B +0.05%) -

Total files change +376B +0.06%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@hugo-vrijswijk hugo-vrijswijk changed the title fix: preserve whitespace when rendering mutant description and statusReason fix(drawer): preserve whitespace when rendering mutant description and statusReason Dec 21, 2023
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also remove the ansi coloring characters?

@hugo-vrijswijk
Copy link
Member Author

hugo-vrijswijk commented Dec 23, 2023

Does this also remove the ansi coloring characters?

No, ansi coloring is a whole different beast. I quickly tested a library that is meant to output html from ansi, but it didn't support everything and requires use of unsafeHtml.

I think it should be possible to create something ourselves and output lit templateResults. Ansi has a system, you just need to understand it. That, and support the different escape characters per language (JS, JVM and C# all have different escape characters for outputting ansi)

@hugo-vrijswijk hugo-vrijswijk merged commit b23731a into master Dec 23, 2023
7 checks passed
@hugo-vrijswijk hugo-vrijswijk deleted the whitespace-pre-wrap branch December 23, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants