refactor(real-time): move update logic to metrics package #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `mutation-testing-metrics` responsible for the real-time calculations in the report. This has a couple of advantages: - Easier to reason about: the metrics are always up-to-date. - Easier to maintain: no ad-hoc calculations are needed anymore - Can be reused from StrykerJS itself, for example, in the console reporter Note: this refactor is needed to enable fine-grained reactivity.
|
Yeah... still needs some more work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
mutation-testing-metricsresponsible for the real-time calculations in the report. This has a couple of advantages:This change was already discussed here: #2453 (comment).
Note: this refactor is needed to enable fine-grained reactivity.