Skip to content

Commit

Permalink
Added links launch in markdown (#63)
Browse files Browse the repository at this point in the history
* Added a markdown widget with auto size text

* Moved comment

* Solved conflicts and bumped version

* Added launch link for markdown.

* Resolved conflicts.

* Changed launch method to Utils.launchUrl
  • Loading branch information
craciunoctavian authored Oct 4, 2020
1 parent 6be5097 commit 086e8b1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions lib/pages/faq/view/faq_page.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'package:acs_upb_mobile/generated/l10n.dart';
import 'package:acs_upb_mobile/pages/faq/model/question.dart';
import 'package:acs_upb_mobile/pages/faq/service/question_provider.dart';
import 'package:acs_upb_mobile/resources/utils.dart';
import 'package:acs_upb_mobile/widgets/scaffold.dart';
import 'package:acs_upb_mobile/widgets/search_bar.dart';
import 'package:acs_upb_mobile/widgets/selectable.dart';
Expand Down Expand Up @@ -158,6 +159,7 @@ class _QuestionsListState extends State<QuestionsList> {
padding: const EdgeInsets.fromLTRB(15, 0, 15, 15),
child: MarkdownBody(
fitContent: false,
onTapLink: Utils.launchURL,
/*
This is a workaround because the strings in Firebase represent
newlines as '\n' and Firebase replaces them with '\\n'. We need
Expand Down
1 change: 1 addition & 0 deletions lib/pages/home/home_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ class HomePage extends StatelessWidget {
fitContent: false,
maxLines: 2,
overflow: TextOverflow.ellipsis,
onTapLink: Utils.launchURL,
/*
This is a workaround because the strings in Firebase represent
newlines as '\n' and Firebase replaces them with '\\n'. We need
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ description: A mobile application for students at ACS UPB.
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
#
# ACS UPB Mobile uses semantic versioning. You can read more in the CONTRIBUTING.md file.
version: 0.10.2+1
version: 0.10.3+1

environment:
sdk: ">=2.6.0 <3.0.0"
Expand Down

0 comments on commit 086e8b1

Please sign in to comment.