fix broken tests

student-hub · Sep 16, 2020 · e6c697a · e6c697a
1 parent c9c0688
commit e6c697a
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 7 deletions.
diff --git a/lib/navigation/bottom_navigation_bar.dart b/lib/navigation/bottom_navigation_bar.dart
@@ -28,8 +28,8 @@ class _AppBottomNavigationBarState extends State<AppBottomNavigationBar>
       HomePage(key: PageStorageKey('Home')),
       ClassesPage(key: PageStorageKey('Classes')),
       PortalPage(key: PageStorageKey('Portal')),
-      ProfilePage(key: PageStorageKey('Profile')),
       PeoplePage(key: PageStorageKey('People')),
+      ProfilePage(key: PageStorageKey('Profile')),
     ];
     tabController = TabController(vsync: this, length: tabs.length);
   }

diff --git a/test/authentication_test.dart b/test/authentication_test.dart
@@ -6,7 +6,9 @@ import 'package:acs_upb_mobile/main.dart';
 import 'package:acs_upb_mobile/pages/filter/model/filter.dart';
 import 'package:acs_upb_mobile/pages/filter/service/filter_provider.dart';
 import 'package:acs_upb_mobile/pages/home/home_page.dart';
+import 'package:acs_upb_mobile/pages/people/service/person_provider.dart';
 import 'package:acs_upb_mobile/pages/portal/service/website_provider.dart';
+import 'package:acs_upb_mobile/pages/profile/profile_page.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:mockito/mockito.dart';
@@ -21,10 +23,13 @@ class MockFilterProvider extends Mock implements FilterProvider {}
 
 class MockWebsiteProvider extends Mock implements WebsiteProvider {}
 
+class MockPersonProvider extends Mock implements PersonProvider {}
+
 void main() {
   AuthProvider mockAuthProvider;
   WebsiteProvider mockWebsiteProvider;
   FilterProvider mockFilterProvider;
+  PersonProvider mockPersonProvider;
 
   setUp(() async {
     WidgetsFlutterBinding.ensureInitialized();
@@ -57,6 +62,12 @@ void main() {
         .thenAnswer((_) => Future.value(Filter(localizedLevelNames: [
               {'en': 'Level', 'ro': 'Nivel'}
             ], root: FilterNode(name: 'root'))));
+
+    mockPersonProvider = MockPersonProvider();
+    // ignore: invalid_use_of_protected_member
+    when(mockPersonProvider.hasListeners).thenReturn(false);
+    when(mockPersonProvider.fetchPeople(context: anyNamed('context')))
+        .thenAnswer((_) => Future.value([]));
   });
 
   group('Login', () {
@@ -376,6 +387,8 @@ void main() {
             create: (_) => mockFilterProvider),
         ChangeNotifierProvider<WebsiteProvider>(
             create: (_) => mockWebsiteProvider),
+        ChangeNotifierProvider<PersonProvider>(
+            create: (_) => mockPersonProvider),
       ], child: MyApp(navigationObservers: [mockObserver])));
       await tester.pumpAndSettle();
 
@@ -386,6 +399,7 @@ void main() {
       await tester.tap(find.byIcon(Icons.person));
       await tester.pumpAndSettle();
 
+      expect(find.byType(ProfilePage), findsOneWidget);
       expect(find.text('Anonymous'), findsOneWidget);
 
       // Press log in button
@@ -407,6 +421,8 @@ void main() {
             create: (_) => mockFilterProvider),
         ChangeNotifierProvider<WebsiteProvider>(
             create: (_) => mockWebsiteProvider),
+        ChangeNotifierProvider<PersonProvider>(
+            create: (_) => mockPersonProvider),
       ], child: MyApp(navigationObservers: [mockObserver])));
       await tester.pumpAndSettle();
 
@@ -417,6 +433,7 @@ void main() {
       await tester.tap(find.byIcon(Icons.person));
       await tester.pumpAndSettle();
 
+      expect(find.byType(ProfilePage), findsOneWidget);
       expect(find.text('John Doe'), findsOneWidget);
 
       // Press log out button

diff --git a/test/integration_test.dart b/test/integration_test.dart
@@ -494,14 +494,16 @@ void main() {
       testWidgets('${size.width}x${size.height}', (WidgetTester tester) async {
         await binding.setSurfaceSize(size);
 
-        await tester.pumpWidget(buildApp());
-        await tester.pumpAndSettle();
+        mockNetworkImagesFor(() async {
+          await tester.pumpWidget(buildApp());
+          await tester.pumpAndSettle();
 
-        // Open profile
-        await tester.tap(find.byIcon(Icons.person));
-        await tester.pumpAndSettle();
+          // Open profile
+          await tester.tap(find.byIcon(Icons.person));
+          await tester.pumpAndSettle();
 
-        expect(find.byType(ProfilePage), findsNWidgets(1));
+          expect(find.byType(ProfilePage), findsNWidgets(1));
+        });
       });
     }
   });