Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert buffered output #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cosmo0920
Copy link
Contributor

Related to #9.
Completely solving #9, we should announce to use aggregating feature plugin like as https://github.com/tagomoris/fluent-plugin-flowcounter in their Fluentd config.


if @flush_interval < 10
log.info("flush_interval less than 10s is not allowed and overwritten to 10s")
@flush_interval = 10
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 seconds is just a default value for the highest-resolution retention period, and it's configurable, right?
Don't you have any other solution to solve the problem...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 seconds is just a default value for the highest-resolution retention period, and it's configurable, right?

Yes. Users can set arbitrary value greater than 10 seconds with flush_interval parameter in configuration.

Don't you have any other solution to solve the problem...?

An another approach is using this plugin fluent-plugin-bufferize together.
This approach is also acceptable for me.
But it remains some pitfall.

Copy link
Owner

@studio3104 studio3104 Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 seconds is just a default value for the highest-resolution retention period, and it's configurable, right?

Yes. Users can set arbitrary value greater than 10 seconds with flush_interval parameter in configuration.

Ah, no, I meant that, "isn't it a problem to forcibly set it to 10 seconds even if the setting on the graphite side is not 10 seconds?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no, I meant that, "isn't it a problem to forcibly set it to 10 seconds even if the setting on the graphite side is not 10 seconds?"

Strictly speaking, there is still problem to time resolution.
But current implementation contains more problem.
With current implementation, Fluentd events cannot wait even if 1 second.
Non-Buffered plugin pass through events with no wait time.

Copy link

@samgurtman-zz samgurtman-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any movement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants