Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Email Manager #22

Merged
merged 7 commits into from
Mar 8, 2024
Merged

[Feature] Email Manager #22

merged 7 commits into from
Mar 8, 2024

Conversation

titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Oct 19, 2023

This PR adds a new EmailManager which can be used to configure a custom SMTP server for sending mail with the wp_mail() function as well as logging success and failures when sending mails.

To-do

  • Add PHPMailer configuration tests
  • Add logger tests

@titouanmathis titouanmathis changed the base branch from master to develop October 19, 2023 12:28
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 66.87%. Comparing base (0302eaf) to head (3b9a704).

Files Patch % Lines
src/Managers/EmailManager.php 55.55% 12 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #22      +/-   ##
=============================================
- Coverage      67.53%   66.87%   -0.67%     
- Complexity       168      179      +11     
=============================================
  Files             11       12       +1     
  Lines            462      489      +27     
=============================================
+ Hits             312      327      +15     
- Misses           150      162      +12     
Flag Coverage Δ
unittests 66.87% <55.55%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titouanmathis titouanmathis force-pushed the feature/email-manager branch 3 times, most recently from 1a7c750 to 5602f2e Compare October 20, 2023 09:59
@titouanmathis titouanmathis force-pushed the feature/email-manager branch from 987e62e to dd59359 Compare March 8, 2024 15:56
@titouanmathis titouanmathis merged commit 45d8172 into develop Mar 8, 2024
6 of 11 checks passed
@titouanmathis titouanmathis deleted the feature/email-manager branch March 8, 2024 16:05
@titouanmathis titouanmathis mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant