Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] AssetsManager methods #23

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Oct 20, 2023

This PR adds 2 methods to easily enqueue assets:

$assets_manager->enqueue_style( 'custom-login-css', 'css/admin/custom-login.css' );
$assets_manager->enqueue_script( 'custom-login-js', 'css/admin/custom-login.js' );

To-do

  • Add tests
  • Update docs

@titouanmathis titouanmathis changed the base branch from master to develop October 20, 2023 14:11
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.40%. Comparing base (45d8172) to head (0d61749).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/Managers/AssetsManager.php 89.47% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #23      +/-   ##
=============================================
+ Coverage      66.87%   67.40%   +0.53%     
- Complexity       179      182       +3     
=============================================
  Files             12       12              
  Lines            489      497       +8     
=============================================
+ Hits             327      335       +8     
  Misses           162      162              
Flag Coverage Δ
unittests 67.40% <90.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titouanmathis titouanmathis force-pushed the feature/assets-manager-methods branch from be5de07 to b046475 Compare March 8, 2024 16:21
@titouanmathis titouanmathis merged commit b629436 into develop Mar 8, 2024
11 checks passed
@titouanmathis titouanmathis deleted the feature/assets-manager-methods branch March 8, 2024 16:27
@titouanmathis titouanmathis mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant