Add unhook options for HTML5 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlomanf any chance you want to refresh this PR? I like the idea a lot. |
|
Hi Nathan, I didn't see this because I've been working in other industries for the last 3 years, but I just checked the plugin and it looks like this has already been done in more recent versions. Unless I'm missing something? |
|
I see what I was missing, it was the priority number. See #21 for updated pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that many of the unhook options that are available for XHTML are not available for HTML5, so I added them. It requires some extra code to handle the priorities.
I also updated
genesis_do_author_boxtogenesis_do_author_box_singleand fixed a bug where some labels were matching up with the wrong checkboxes.