Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniswap V2 #95

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Uniswap V2 #95

merged 1 commit into from
Apr 1, 2021

Conversation

marcelomorgado
Copy link
Collaborator

Closes #67

@vercel
Copy link

vercel bot commented Mar 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/study-defi/money-legos/5S1rDSk6xVSpvaSa5SVJnSJBDKYi
✅ Preview: https://money-legos-git-uniswap-v2-study-defi.vercel.app

@marcelomorgado
Copy link
Collaborator Author

CI failed but the Uniswap V2 tests are passing here. We will have consistent (and faster) tests by using hardhat + Alchemy IMO. Refs #48

Copy link
Member

@adrianmcli adrianmcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@adrianmcli
Copy link
Member

looks like some of the tests are failing, but feel free to merge anyway for now.
should be much easier to get the tests working again after moving to hardhat forking

@marcelomorgado marcelomorgado merged commit adb36b3 into master Apr 1, 2021
@marcelomorgado marcelomorgado deleted the uniswap-v2 branch April 1, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniswap v2
2 participants