Skip to content

Commit

Permalink
Adds a docker inspect for the image to know what version was pulled
Browse files Browse the repository at this point in the history
  • Loading branch information
stumpylog committed Dec 11, 2023
1 parent 22bd9e0 commit 766418f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .docker/docker-compose.ci-test-edge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

version: "3"
services:
gotenberg-client-test-server:
gotenberg-client-test-edge-server:
image: docker.io/gotenberg/gotenberg:edge
hostname: gotenberg-client-test-server
container_name: gotenberg-client-test-server
hostname: gotenberg-client-test-edge-server
container_name: gotenberg-client-test-edge-server
network_mode: host
restart: unless-stopped
command:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ jobs:
docker compose --file ${GITHUB_WORKSPACE}/.docker/docker-compose.ci-test.yml up --detach
echo "Wait for container to be started"
sleep 5
docker inspect gotenberg-client-test-server
-
name: Install poppler-utils
run: |
Expand Down Expand Up @@ -113,6 +114,7 @@ jobs:
docker compose --file ${GITHUB_WORKSPACE}/.docker/docker-compose.ci-test-edge.yml up --detach
echo "Wait for container to be started"
sleep 5
docker inspect gotenberg-client-test-edge-server
-
name: Install poppler-utils
run: |
Expand All @@ -131,6 +133,7 @@ jobs:
pip install --upgrade hatch
-
name: Run tests
continue-on-error: true
run: hatch run cov
-
name: Stop containers
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Implemented an internal workaround for older Gotenberg versions and their handling of non-latin filenames.
- When detected, the files will be copied into a temporary directory and the filename cleaned
- Gotenberg 8.0.0 will start implementing something similar once released
- The pulled Gotenberg image is now inspected, allowing local re-creation of failures against specific digests
- The `:edge` tag testing is now allowed to fail

## [0.4.0] - 2023-12-04

Expand Down

0 comments on commit 766418f

Please sign in to comment.