-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Para components should use theme.fontSize.base
or theme.fontSize.text
#1661
Comments
At the moment, my solution is to duplicate the theme as a direct style to the Para component. Something like:
|
I think it has
And the Feel free to send a pull request with a fix! 👾 |
Hello, I would like to be assigned to this issue. |
@senadglojnaric sure, go for it! 👍 |
I have a question about testing. I ran a test on my clone repo without changing anything in the code. Like an initial test. Here's my debug log file: 0 info it worked if it ends with ok I'm asking this because I found a solution for this issue #1661 and I wanted to run testing and send pull request. |
@senadglojnaric It looks like what's happening is there's a lint issue. If you run |
Hello, first of all, thanks for helping me! After that I get this message to the console: Test Suites: 6 failed, 114 passed, 120 total npm ERR! A complete log of this run can be found in: It seems that 6 Testsuits and 22 Tests are failing. Snapshots are all OK. This is how my debug.log looks now: 0 info it worked if it ends with ok And this is an example of one of the failing tests printed in the output (first one): Summary of all failing tests
|
I went through all the test output that had failed. It seems that they all have one thing in common. They check filename paths. |
Oh good find! Are you able to resolve your issue then? |
I think so. I'm going to ignore failing tests for now. Windows and Linux both read forwardslash and backslash in filepaths. But in the tests, they are compared as strings. Anyway, I'm going to send pull request ignoring these tests. |
Current behavior
When stylegudist is configured to use a font size for base and/or text to be anything other than 16px, the paragraph content generated from markdown does not use the specified font size.
Question: Is a markdown paragraph considered to be either
base
ortext
? I am assuming it should betext
at the very least.To reproduce
Config:
Some markdown file:
styleguidist/example#8
Expected behavior
The generated paragraph content should use the theme provided.
Or there should be some explanation of how the "theme" is defined: How is a paragraph not "text" or "base"?
The text was updated successfully, but these errors were encountered: