Skip to content

Commit

Permalink
[🚑️]: Hotfix critical bugs (#89)
Browse files Browse the repository at this point in the history
* Fix an issue related to the accessibility name being calculated wrong

* Update github files

* Fix an issue with `document is not defined`

* Update `README.md`

* Add `semver`

* Updating contributing docs

* Opt-in `semver`

* Update pnpm version

* Remove `packageManager`
  • Loading branch information
mimshins authored Apr 21, 2024
1 parent 78aa444 commit c26c76a
Show file tree
Hide file tree
Showing 11 changed files with 3,907 additions and 3,187 deletions.
4 changes: 0 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,3 @@ Choose the right checklist for the change that you're making:
- [ ] Tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
4 changes: 2 additions & 2 deletions .github/workflows/development.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: pnpm/action-setup@v3
with:
version: 8
version: 9

- uses: actions/setup-node@v4
with:
Expand All @@ -43,7 +43,7 @@ jobs:
- name: "🔧 setup pnpm"
uses: pnpm/action-setup@v3
with:
version: 8
version: 9

- name: "🔧 setup node"
uses: actions/setup-node@v4
Expand Down
22 changes: 21 additions & 1 deletion .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

- uses: pnpm/action-setup@v3
with:
version: 8
version: 9

- uses: actions/setup-node@v4
with:
Expand All @@ -25,17 +25,37 @@ jobs:
- name: "🧱 build package"
run: pnpm build

- name: "🗄️ archive package"
uses: actions/upload-artifact@v4
with:
name: dist
path: dist

publish-npm:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v3
with:
version: 9

- uses: actions/setup-node@v4
with:
node-version: 20
cache: "pnpm"
registry-url: https://registry.npmjs.org/

- name: "📦 install dependencies"
run: pnpm install

- name: "🚚 download package"
uses: actions/download-artifact@v4
with:
name: dist
path: dist

- name: "🚀 publish package"
run: npx tsx ./scripts/ci/publish-package.ts
env:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The following is a set of guidelines for contributing to StylelessUi and its pac

## Code of Conduct

This project and everyone participating in it is governed by the [Code of Conduct](https://github.com/styleless-ui/react-styleless-ui/blob/next/CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code.
This project and everyone participating in it is governed by the [Code of Conduct](https://github.com/styleless-ui/react-styleless-ui/blob/stable/CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code.

## A large spectrum of contributions

Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,10 @@ Our project [roadmap](https://github.com/orgs/styleless-ui/projects/1/views/1?vi

## Contributing

Read the [contributing guide](https://github.com/styleless-ui/react-styleless-ui/blob/next/CONTRIBUTING.md) to learn about our development process, how to propose bug fixes and improvements, and how to build and test your changes.
Read the [contributing guide](https://github.com/styleless-ui/react-styleless-ui/blob/stable/CONTRIBUTING.md) to learn about our development process, how to propose bug fixes and improvements, and how to build and test your changes.

Contributing to styleless-ui is about more than just issues and pull requests! There are many other ways to support the project beyond contributing to the code base.


## License

This project is licensed under the terms of the [MIT license](https://github.com/styleless-ui/react-styleless-ui/blob/next/LICENSE).
This project is licensed under the terms of the [MIT license](https://github.com/styleless-ui/react-styleless-ui/blob/stable/LICENSE).
2 changes: 1 addition & 1 deletion lib/Button/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ const ButtonBase = <
(node as HTMLButtonElement).disabled = disabled;
}

const accessibleName = computeAccessibleName(node);
const accessibleName = computeAccessibleName(node, { hidden: true });

if (!accessibleName) {
logger(
Expand Down
2 changes: 1 addition & 1 deletion lib/Dialog/Dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ const DialogBase = (props: Props, ref: React.Ref<HTMLDivElement>) => {

const context: DialogContextValue = { open, role, emitClose };

if (document) {
if (typeof document !== "undefined") {
// eslint-disable-next-line react-hooks/rules-of-hooks
useEventListener(
{
Expand Down
2 changes: 1 addition & 1 deletion lib/Toggle/Toggle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ const ToggleBase = (props: Props, ref: React.Ref<HTMLButtonElement>) => {

if (!node) return;

const accessibleName = computeAccessibleName(node);
const accessibleName = computeAccessibleName(node, { hidden: true });

if (!accessibleName) {
logger(
Expand Down
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@styleless-ui/react",
"version": "1.0.0-rc.0",
"version": "1.0.0-rc.1",
"description": "Completely unstyled, headless and accessible React UI components.",
"author": "mimshins <[email protected]>",
"license": "MIT",
Expand All @@ -14,8 +14,7 @@
},
"publishConfig": {
"access": "public",
"registry": "https://registry.npmjs.org/",
"tag": "rc"
"registry": "https://registry.npmjs.org/"
},
"keywords": [
"ui",
Expand Down Expand Up @@ -53,6 +52,7 @@
"@types/react": "^18.2.70",
"@types/react-dom": "^18.2.22",
"@types/react-is": "^18.2.4",
"@types/semver": "^7.5.8",
"@typescript-eslint/eslint-plugin": "^7.3.1",
"@typescript-eslint/parser": "^7.3.1",
"classnames": "^2.5.1",
Expand All @@ -75,6 +75,7 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"rimraf": "^5.0.5",
"semver": "^7.6.0",
"terser": "^5.29.2",
"ts-jest": "^29.1.2",
"tsx": "^4.7.1",
Expand Down
Loading

0 comments on commit c26c76a

Please sign in to comment.