Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable DFP and update with new methods/config #168

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Re-enable DFP and update with new methods/config #168

merged 5 commits into from
Oct 11, 2023

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket:
SDK-1225
SDK-1226

Changes:

  1. Reverts the commit that removed DFP
  2. Updates the GetTelemetryID call to pass an object with the platform
  3. Adds a top-level DFP object that exposes a getTelemetryId method that delegates to the existing DFPProvider

Notes:

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

danny-stytch
danny-stytch reviewed Oct 10, 2023
View reviewed changes
Copy link

@danny-stytch danny-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhaven-stytch jhaven-stytch changed the base branch from main to release/0.19.0 October 11, 2023 13:52
@jhaven-stytch jhaven-stytch merged commit 897f3e2 into release/0.19.0 Oct 11, 2023
@jhaven-stytch jhaven-stytch deleted the jordan/dfp-take-2 branch October 11, 2023 13:53
jhaven-stytch added a commit that referenced this pull request Oct 11, 2023
@jhaven-stytch
Release/0.19.0 (#170)
a19f140 
* Re-enable DFP and update with new methods/config (#168)

* Revert "Remove DFP from main (#166)"

This reverts commit 737531b.

* SDK-1225 Add platform to DFP call

* SDK-1226 add top-level DFP object for retrieving DFP Telemetry ID

* Add codegen methods

* Make the extension properties always available and only gate the implementation details

* Remove CocoaPods and Carthage (#169)

* Seems to be working for CocoaPods now

* Add note about necessary Linker Flag, remove Carthage as a supported package manager

* Remove XCFramework creation and carthage steps from workflows

* Remove all cocoapods and carthage stuff

* Remove cocoapods from gemfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danny-stytch danny-stytch danny-stytch left review comments

@susie-stytch susie-stytch susie-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhaven-stytch @danny-stytch @susie-stytch