Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS B2C Crypto Wallets client #206

Merged
merged 5 commits into from
Feb 9, 2024
Merged

iOS B2C Crypto Wallets client #206

merged 5 commits into from
Feb 9, 2024

Conversation

susie-stytch
Copy link
Contributor

Linear Ticket: SDK-1469

Changes:

Adds stytch.cryptoWallets with the following methods:

  • authenticateStart
  • authenticate

Notes:

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

Copy link
Contributor

@jhaven-stytch jhaven-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good, I just wanna confirm we're on the same page w/r/t the signing of challenges: since iOS and Android don't have the same concept of a wallet manager (or whatever it's called) like we do in the JS SDK, our SDK has no responsibility to perform the signing flow, right? We're just an intermediary between passing the challenge back to the developer, and then it's their responsibility to sign the challenge and return it to us. Thats my understanding, and what appears to be happening here, just wanna make sure!

@jhaven-stytch jhaven-stytch merged commit 3039d73 into main Feb 9, 2024
7 checks passed
@jhaven-stytch jhaven-stytch deleted the susie-sdk-1469 branch February 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants