SDK-1561 Fix issue with Biometrics registration #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Prefer kSecAttrAccessControl if both are requested
alex-stytch
approved these changes
Apr 2, 2024
jhaven-stytch
deleted the
jordan/SDK-1561-iOS-biometrics-registration-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kSecAttrAccessibleandkSecAttrAccessControlare mutually exclusive. The first attribute is used to make a keychain item available after the first unlock (which we use so session tokens are available during fetches when the app is backgrounded) and the second one we use to specify that something can only be accessed with a biometric. Seems obvious in hindsight that they wouldn't work together!Linear Ticket: SDK-1561
Changes:
kSecAttrAccessibleandkSecAttrAccessControlare requested for the same keychain item, disregard thekSecAttrAccessibleattribute, preferringkSecAttrAccessControlNotes:
Checklist: