Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password discovery #380

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Add password discovery #380

merged 9 commits into from
Jan 23, 2025

Conversation

nidal-stytch
Copy link
Contributor

@nidal-stytch nidal-stytch commented Jan 18, 2025

[iOS] Password Discovery (headless and UI)
[iOS][B2B UI] Modify ordering logic to place or separators before and after input types of email and password

Changes:

  1. Add headless password discovery endpoints.
  2. Parse out redirect type from deep link url used for password discovery.
  3. Add password discovery to the B2B UI.
  4. Modify product ordering logic and unit tests to more nicely place the or separators around the input products.
  5. Modify makefile's test commands to use specified version of the os's and simulators, not ones pulled from the command line.
  6. Fix all previously broken tests!!!
  7. Genericize the resend password reset email logic to be shared better between the password forgot screen and the email confirmation screen resend button.
  8. Clean up and logically group the AuthenticationOperations file.

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-01-21.at.15.50.35.mp4

@nidal-stytch nidal-stytch force-pushed the password-discovery branch 23 times, most recently from cd97c91 to 641455b Compare January 21, 2025 21:12
@nidal-stytch nidal-stytch force-pushed the password-discovery branch 4 times, most recently from 869edbc to 11d8bd4 Compare January 21, 2025 21:55
@nidal-stytch nidal-stytch force-pushed the password-discovery branch 8 times, most recently from b5de9fa to 041c32f Compare January 22, 2025 18:45
@nidal-stytch nidal-stytch force-pushed the password-discovery branch 4 times, most recently from 7a71809 to a441cd2 Compare January 22, 2025 21:42

.PHONY: test-watchos
test-watchos: codegen
$(TEST) watchsimulator$(WATCHOS_VERSION) -destination "OS=$(WATCHOS_VERSION),name=Apple Watch Ultra (49mm)" | $(XCPRETTY)
$(TEST) watchsimulator10.0 -destination "OS=10.0,name=Apple Watch Ultra (49mm)" | $(XCPRETTY)

.PHONY: tools
tools:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to just hard code all the test versions here in the makefile, made things so much simpler to know exactly what was going on, the tests not running had to do with not finding the right os and device combo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That way when we bump the version of Xcode in the test.yml file we can also modify these version to match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added:

@xcodebuild -showsdks
@xcrun simctl list devices

Because when we go to bump Xcode in the future we can see what available devices and iOS's we have on the first failure and update the hard coding appropriately.

@nidal-stytch nidal-stytch force-pushed the password-discovery branch 6 times, most recently from 57cd80d to 6669524 Compare January 23, 2025 00:09
@nidal-stytch nidal-stytch merged commit 4760365 into main Jan 23, 2025
8 checks passed
@nidal-stytch nidal-stytch deleted the password-discovery branch January 23, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants