This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Block editor: change block type #1047
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonbrander
commented
Dec 21, 2023
| @@ -185,3 +185,16 @@ extension UIColor { | |||
| UIColor(Color.accentColor) | |||
| } | |||
| } | |||
|
|
|||
| extension ShadowStyle { | |||
| static func brandShadowLg( | |||
There was a problem hiding this comment.
Introduce the concept of shadow presets. In future we will want to systematize our shadows so as to have a coherent sense of distance and lighting.
This allows us to anchor it at the bottom of the screen.
Still need to handle dark mode for destructive button
...and change heading icon.
These structs allow us to fully and completely describe the colors for various states of a button.
Wraps representable and coordinates representable and supporting SwiftUI views, like the select menu.
This will allow us to make the Update type generic if needed.
...use ControllerUpdateProtocol instead. The failure we were experiencing in the previous commit was due to not implementing ControllerModelProtocol (whoops), but really there is no need. We have enough information to dispatch on constraints.
We'll try to cut down on the amount of repetition by bundling together common configurations into extensions.
Remove divider. Too visually noisy.
Was referencing wrong color constant.
We take it as a given that all blocks have a selection state, text, and text selection. This is a good simplifying assumption because it means most of our code paths no longer have to go through switch arms. Blocks that don't need text can simply leave it empty.
...and pipe animation duration through to controller
...as well as block delete. We'll need a confirmation menu for this eventually, but we can start here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1042