Updating rule: attachment_cve_2023_38831.yml #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding delivr.to fix.
rw-access
reviewed
Sep 29, 2023
| @@ -22,19 +22,19 @@ source: | | |||
| // zip contains a path with spaces and file extensions | |||
| // lure.pdf /lure.pdf .cmd | |||
| // | |||
| // /= Initial file name | |||
| // /= Initial file name (including any spaces) | |||
There was a problem hiding this comment.
Is it okay if this includes dots too? Should we do . here or [\w\s]?
There was a problem hiding this comment.
@ajpc500 would know better
There was a problem hiding this comment.
The recent Agent Tesla file name is RFQ 23-301892.pdf /RFQ 23-301892.pdf .cmd. So [\w\s] specifically wouldn't match on the hyphens, nor on brackets. I haven't tested it, but I don't think a double-extension (e.g. .tar.gz) would have any impact on the ability to exploit CVE-2023-38831, so we could include . here. There's potential to refine this to a subset of symbols, but will defer to you re. any rule performance improvement in doing that!
morriscode
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding delivr.to fix.