Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: impersonation_quickbooks.yml #862

Merged
merged 7 commits into from
Nov 4, 2023

Conversation

aidenmitchell
Copy link
Member

No description provided.

@notion-workspace
Copy link

lnv 44358 Due

@aidenmitchell aidenmitchell requested a review from a team October 17, 2023 20:12
@morriscode
Copy link
Member

/update-test-rules

github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
New rule: impersonation_quickbooks.yml by @aidenmitchell
#862
Source SHA f65c491
Triggered by @morriscode
@morriscode
Copy link
Member

fired 47 times no other rule overlap for 90% of them. Going to hold off on merging as the impersonation rules are prone to trusted domain firings.

@morriscode
Copy link
Member

Can we add the highly trusted domain logic here @aidenmitchell

Copy link
Member

@morriscode morriscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚕

@morriscode morriscode enabled auto-merge (squash) November 4, 2023 18:21
@morriscode morriscode merged commit 7323bab into sublime-security:main Nov 4, 2023
3 checks passed
@aidenmitchell aidenmitchell deleted the patch-65 branch November 4, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants