Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regex in rules to remove line-based matches #868

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Update regex in rules to remove line-based matches #868

merged 2 commits into from
Oct 19, 2023

Conversation

rw-access
Copy link
Contributor

Line-based tokens ^ and $ don't work for backtesting. We should be using regex.match in these cases anyway.

@rw-access rw-access requested a review from a team October 18, 2023 22:40
morriscode
morriscode approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@morriscode morriscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💲

@rw-access rw-access enabled auto-merge (squash) October 19, 2023 17:18
@rw-access rw-access merged commit d96d03a into main Oct 19, 2023
3 checks passed
@rw-access rw-access deleted the ross.update-regex-line-chars branch October 19, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscode morriscode morriscode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rw-access @morriscode