Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala] Fix with keyword after comments in class declarations #3779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deathaxe
Copy link
Collaborator

@deathaxe deathaxe commented May 26, 2023

Fixes #3778

@djspiewak: Thoughts?

@djspiewak
Copy link
Contributor

Possibly! It looks promising. Can you add a test showing that it still infers the double newline when one line is a comment?

@deathaxe
Copy link
Collaborator Author

Can you give an example of what's missing in the added test cases?

@jrappen
Copy link
Contributor

jrappen commented Oct 31, 2023

/ping @djspiewak ⬆️

Copy link
Collaborator

@FichteFoll FichteFoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Scala, but this looks reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Scala] "with" keywords highlighted as out of place when comment between them and extends
4 participants