Proposal to support subctl installation via krew #195
Conversation
Jaanki
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr195/Jaanki/subctl-krew |
Jaanki
force-pushed
the
subctl-krew
branch
2 times, most recently
from
b871ca3 to
4ecda83
Compare
Epic: submariner-io/enhancements#195 Depends on submariner-io/enhancements#195 Signed-off-by: Janki Chhatbar <[email protected]>
|
|
||
| Once this is done, users would be able to install subctl using krew: | ||
|
|
||
| kubectl krew install subm |
There was a problem hiding this comment.
Can you also include an example on how to install a specific version of subctl?
There was a problem hiding this comment.
Krew (the package manager for kubectl plugins) does not have built-in support for installing specific versions of a plugin. Krew is designed to fetch and install the latest available version of a plugin from the configured plugin index. However, we can provide multiple versions of their plugins in the plugin index, allowing users to choose which version to install. This facility will not be provided at the moment but can be enhanced in the future.
|
|
||
| ## Summary | ||
|
|
||
| krew is a kubectl plugin that makes lifecycle management of kubectl plugins easy. The idea is to have `subctl` as a kubectl plugin and be |
There was a problem hiding this comment.
nitpick: Shouldn't krew be krew?
There was a problem hiding this comment.
It should be Krew (see the website).
There was a problem hiding this comment.
It should be Krew (see the website).
Since one of the goals of this is to use it with oc, would it cause confusion for downstream users?
There was a problem hiding this comment.
updated at other relevant places too.
There was a problem hiding this comment.
It should be Krew (see the website).
Since one of the goals of this is to use it with
oc, would it cause confusion for downstream users?
Plugins installed using Krew work with both kubectl and oc:
$ oc subm
An installer for Submariner
...
(My kubectl-subm is old.)
There was a problem hiding this comment.
yes, that's also one of the golas: to make subctl (built with build constraints) available downstream via oc as part of OpenShift CLI manager.
| and use `subctl` as `kubectl-subm` or `kubectl subm`. | ||
|
|
||
| $ kubectl subm | ||
| An installer for Submariner |
There was a problem hiding this comment.
Since subctl provides much more than installation, this should be changed to reflect that. Maybe something like:
A utility tool for Submariner
There was a problem hiding this comment.
nit: I guess Vishal wanted the text to be updated accordingly.
There was a problem hiding this comment.
Yes, this text should also be change to make it clear that subctl is more than just an installer.
EDIT: Since text is already changed in subctl output, approving.
We’d publish one, full-featured plugin corresponding to upstream |
Closes: submariner-io#182 Signed-off-by: Janki Chhatbar <[email protected]>
Epic: submariner-io/enhancements#195 Depends on submariner-io/enhancements#195 Signed-off-by: Janki Chhatbar <[email protected]>
| and use `subctl` as `kubectl-subm` or `kubectl subm`. | ||
|
|
||
| $ kubectl subm | ||
| An installer for Submariner |
There was a problem hiding this comment.
nit: I guess Vishal wanted the text to be updated accordingly.
| and use `subctl` as `kubectl-subm` or `kubectl subm`. | ||
|
|
||
| $ kubectl subm | ||
| An installer for Submariner |
There was a problem hiding this comment.
Yes, this text should also be change to make it clear that subctl is more than just an installer.
EDIT: Since text is already changed in subctl output, approving.
Jaanki
requested review from
dfarrell07,
nyechiel,
manosnoam,
MaxBab,
aswinsuryan,
yboaron,
mkolesnik and
maayanf24
|
🤖 Closed branches: [z_pr195/Jaanki/subctl-krew] |
Closes: #182