Update the binary path #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaanki
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr51/Jaanki/update_subctl_path |
skitt
requested changes
Jul 17, 2023
Jaanki
force-pushed
the
update_subctl_path
branch
from
38c2904 to
3bf43b3
Compare
Jaanki
force-pushed
the
update_subctl_path
branch
from
3bf43b3 to
45c5e24
Compare
|
devel check will pass only after merging submariner-io/subctl#837 |
skitt
requested changes
Jul 18, 2023
Jaanki
force-pushed
the
update_subctl_path
branch
2 times, most recently
from
5bb0e26 to
da24050
Compare
in accordance with submariner-io/subctl#837 changing the `subctl` binary location. Epic: submariner-io/enhancements#182 Depends on submariner-io/subctl#837 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
force-pushed
the
update_subctl_path
branch
from
da24050 to
70a8c58
Compare
8 tasks
skitt
approved these changes
Jul 19, 2023
sridhargaddam
approved these changes
Jul 19, 2023
|
🤖 Closed branches: [z_pr51/Jaanki/update_subctl_path] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in accordance with submariner-io/subctl#837 changing the
subctlbinary location.Epic: submariner-io/enhancements#182