Address errchkjson linter errchkjson

Fix "Error return value of `encoding/json.MarshalIndent` is not checked"

Signed-off-by: Tom Pantelis <[email protected]>

pkg/agent/controller/agent.go

@@ -20,7 +20,6 @@ package controller
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 	"reflect"
 	"strconv"
@@ -29,6 +28,7 @@ import (
 	"github.com/submariner-io/admiral/pkg/federate"
 	"github.com/submariner-io/admiral/pkg/ipam"
 	"github.com/submariner-io/admiral/pkg/log"
+	"github.com/submariner-io/admiral/pkg/resource"
 	"github.com/submariner-io/admiral/pkg/syncer"
 	"github.com/submariner-io/admiral/pkg/syncer/broker"
 	"github.com/submariner-io/lighthouse/pkg/constants"
@@ -496,6 +496,5 @@ type serviceImportStringer struct {
 }
 
 func (s serviceImportStringer) String() string {
-	spec, _ := json.MarshalIndent(&s.Spec, "", "  ")
-	return "spec: " + string(spec)
+	return "spec: " + resource.ToJSON(&s.Spec)
 }

pkg/agent/controller/service_endpoint_slices.go

@@ -20,7 +20,6 @@ package controller
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 	"strconv"
 	"strings"
@@ -380,9 +379,9 @@ type endpointSliceStringer struct {
 }
 
 func (s endpointSliceStringer) String() string {
-	labels, _ := json.MarshalIndent(&s.Labels, "", "  ")
-	ports, _ := json.MarshalIndent(&s.Ports, "", "  ")
-	endpoints, _ := json.MarshalIndent(&s.Endpoints, "", "  ")
+	labels := resource.ToJSON(&s.Labels)
+	ports := resource.ToJSON(&s.Ports)
+	endpoints := resource.ToJSON(&s.Endpoints)
 
 	return fmt.Sprintf("\nlabels: %s\naddressType: %s\nendpoints: %s\nports: %s", labels, s.AddressType, endpoints, ports)
 }