Automated backport of #1472: Handle transient ServiceImport delete in the resolver #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so we get timestamps and pretty formatting. Signed-off-by: Tom Pantelis <[email protected]>
During DR testing where the broker cluster is recovered from a backup, it was observed that the coredns plugin resolver received a ServiceImport delete event followed by an add event while the EndpointSlice remained. This resulted in failed DNS queries b/c the service info was removed. The assumption is that a ServiceImport deletion means the service was unexported, which is normally the case. However, during DR scenarios, transient deletions may occur due to reconciliation on LH agent startup if it observes a local copy of a remote resource doesn't yet exist on the broker due to timing. When this occurs a restart of the coredns pod is required to correct it. To alleviate this issue, make the resolver more resilient by only removing the service info data when there's no more cluster data, ie when all the cluster EndpointSlices are deleted. Normally, on unexport, the EndpointSlices are deleted after the aggregated ServiceImport is deleted. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1473/tpantelis/automated-backport-of-#1472-upstream-release-0.16 |
tpantelis
changed the title
skitt
approved these changes
Jan 2, 2024
sridhargaddam
approved these changes
Jan 2, 2024
|
🤖 Closed branches: [z_pr1473/tpantelis/automated-backport-of-#1472-upstream-release-0.16] |
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 3, 2024
Release notes for submariner-io/lighthouse#1473 Signed-off-by: Tom Pantelis <[email protected]>
aswinsuryan
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 5, 2024
Release notes for submariner-io/lighthouse#1473 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/lighthouse#1473 Signed-off-by: Tom Pantelis <[email protected]>
aswinsuryan
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/lighthouse#1473 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
deleted the
automated-backport-of-#1472-upstream-release-0.16
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1472 on release-0.16.
#1472: Use zerolog in coredns plugin
For details on the backport process, see the backport requests page.