Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subctl command variable #804

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

Jaanki
Copy link
Contributor

@Jaanki Jaanki commented Jun 19, 2023

so that the help can display proper output when subctl is used as a standalone CLI or as kubectl-plugin.

Epic: submariner-io/enhancements#182

When used as kubectl plugin named subm, the usage and help message displayed would be

$ kubectl subm                                                                                              
An installer for Submariner

Usage:
  kubectl-subm [command]

Available Commands:
  benchmark           Benchmark tests
  cloud               Cloud operations
  completion          Generate the autocompletion script for the specified shell
  deploy-broker       Deploys the broker
  diagnose            Run diagnostic checks on the Submariner deployment and report any issues
  export              Exports a resource to other clusters
  gather              Gather troubleshooting information from a cluster
  help                Help about any command
  join                Connect a cluster to an existing broker
  recover-broker-info Recovers the broker-info.subm file from the installed Broker
  show                Show information about Submariner
  unexport            Stop a resource from being exported to other clusters
  uninstall           Uninstall Submariner and its components
  verify              Run verifications between two clusters
  version             Get version information on subctl

Flags:
  -h, --help   help for kubectl-subm

Use "kubectl-subm [command] --help" for more information about a command.

so that the help can display proper output when subctl is used as a
standalone CLI or as kubectl-plugin.

Epic: submariner-io/enhancements#182

Signed-off-by: Janki Chhatbar <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr804/Jaanki/generalize_cmd_name
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@Jaanki Jaanki self-assigned this Jun 19, 2023
@Jaanki Jaanki added the ready-to-test When a PR is ready for full E2E testing label Jul 3, 2023
@sridhargaddam sridhargaddam merged commit 78c7cf6 into submariner-io:devel Jul 3, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr804/Jaanki/generalize_cmd_name]

@Jaanki Jaanki deleted the generalize_cmd_name branch July 4, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants