forked from subquery/subql
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New fork detection for probabilistic finalization chains #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report❌ An unexpected error occurred. For more details, check console
Test suite run failedFailed tests: 5/62. Failed suites: 5/11.
Report generated by 🧪jest coverage report action from 6f7474a |
stwiname
commented
Nov 23, 2023
type: 'number', | ||
}, | ||
'block-fork-reindex': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im open to better name suggestions
11 tasks
ianhe8x
reviewed
Nov 26, 2023
ianhe8x
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a different fork detection method for chains that don't support finalization. If a fork is detected before the probabilistic finalized block it will fallback to using POI to reindex to the last block with an operation that has a valid block hash. If POI is not enabled it will reindex back
block-fork-reindex
blocks, this defaults to 1000.Type of change
Please delete options that are not relevant.
Checklist