Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter validation with not null filter #341

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

stwiname
Copy link

Description

With a recent validation improvement to check filters exist in ABIs, there was no check to allow the !null filter. This adds it in.

Also defines a const to a void magic strings for '!null'

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Aug 26, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 53.24% 3332/6258
🟡 Branches 68.39% 411/601
🔴 Functions 52.3% 148/283
🔴 Lines 53.24% 3332/6258

Test suite run success

87 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 9737ce8

@stwiname stwiname merged commit 67a49f0 into main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants