-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use antlr parser to parse the types in extensions #64
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 55.00% 56.50% +1.50%
==========================================
Files 36 38 +2
Lines 8177 8227 +50
==========================================
+ Hits 4498 4649 +151
+ Misses 3476 3382 -94
+ Partials 203 196 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update codecov as part of this patch to ignore the newly generated files.
Done |
return l.errors[0] | ||
} | ||
|
||
func (l *simpleErrorListener) GetErrors() []string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect tests to use GetErrors() instead of GetError() to detect when multiple errors appear (not just the one expected one).
…le with generate.go
go generate
changes to pull the grammar from substarit-core and auto generate antlr parser. For now I included the files in this PR.