[Substrait] Minor fixes in importScalarFunction. (NFC) (iree-org/ir…

…ee-llvm-sandbox#860) Two minor improvements: (1) Use a `const` reference where there was a superfluous copy before (for a protobuf message) and (2) fix a typo in a comment. Signed-off-by: Ingo Müller <[email protected]>
substrait-io · Oct 15, 2024 · 05573a3 · 05573a3
1 parent c06eba5
commit 05573a3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/Target/SubstraitPB/Import.cpp b/lib/Target/SubstraitPB/Import.cpp
@@ -588,7 +588,7 @@ importScalarFunction(ImplicitLocOpBuilder builder,
   Location loc = UnknownLoc::get(context);
 
   // Import `output_type`.
-  proto::Type outputType = message.output_type();
+  const proto::Type &outputType = message.output_type();
   FailureOr<mlir::Type> mlirOutputType = importType(context, outputType);
   if (failed(mlirOutputType))
     return failure();
@@ -614,7 +614,7 @@ importScalarFunction(ImplicitLocOpBuilder builder,
     operands.push_back((*expression)->getResult(0));
   }
 
-  // Import `function_refernece` field.
+  // Import `function_reference` field.
   int32_t anchor = message.function_reference();
   std::string calleeSymName = buildFuncSymName(anchor);