Address review comments

substrait-io · Nov 4, 2024 · 6df3767 · 6df3767
1 parent 7204ac3
commit 6df3767
Show file tree

Hide file tree

Showing 8 changed files with 3,635 additions and 4,640 deletions.
diff --git a/grammar/FuncTestCaseLexer.g4 b/grammar/FuncTestCaseLexer.g4
@@ -8,8 +8,9 @@ options {
 
 Whitespace    : [ \t\n\r]+ -> channel(HIDDEN) ;
 
-SubstraitScalarTest: '### SUBSTRAIT_SCALAR_TEST:';
-SubstraitInclude: '### SUBSTRAIT_INCLUDE:';
+TripleHash: '###';
+SubstraitScalarTest: 'SUBSTRAIT_SCALAR_TEST';
+SubstraitInclude: 'SUBSTRAIT_INCLUDE';
 
 FormatVersion
     : 'v' DIGIT+ ('.' DIGIT+)?
@@ -21,8 +22,8 @@ DescriptionLine
 
 ErrorResult: '<!ERROR>';
 UndefineResult: '<!UNDEFINED>';
-Overflow: 'overlfow';
-Rounding: 'rounding';
+Overflow: 'OVERLFOW';
+Rounding: 'ROUNDING';
 Error: 'ERROR';
 Saturate: 'SATURATE';
 Silent: 'SILENT';

diff --git a/grammar/FuncTestCaseParser.g4 b/grammar/FuncTestCaseParser.g4
@@ -15,11 +15,11 @@ header
     ;
 
 version
-    : SubstraitScalarTest FormatVersion
+    : TripleHash SubstraitScalarTest Colon FormatVersion
     ;
 
 include
-    : SubstraitInclude StringLiteral (Comma StringLiteral)*
+    : TripleHash SubstraitInclude Colon StringLiteral (Comma StringLiteral)*
     ;
 
 testGroupDescription

diff --git a/tests/coverage/antlr_parser/FuncTestCaseLexer.interp b/tests/coverage/antlr_parser/FuncTestCaseLexer.interp