Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only download pytorch model #23

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

samos123
Copy link
Contributor

@samos123 samos123 commented Aug 4, 2023

Fixes #20

This reduces the model size of many models by 2x or 3x because safetensors and tensorflow model doesn't get used by any of our images. That being said, we might want to consider exposing this as a param in a follow up PR.

@samos123 samos123 requested a review from nstogner August 4, 2023 04:59
Copy link
Contributor

@brandonjbjelland brandonjbjelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion but LGTM 🚢

@brandonjbjelland
Copy link
Contributor

Nice find eliminating the tensorflow cruft here. 👯

@samos123 samos123 merged commit 5e9d69c into main Aug 4, 2023
6 checks passed
@brandonjbjelland brandonjbjelland deleted the fix-20-only-download-pytorch-model branch August 4, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model-loader-huggingface: Prevent downloading both safe tensors and pytorch model
2 participants