Skip to content

Formatter, Linter and fixes #1

Formatter, Linter and fixes

Formatter, Linter and fixes #1

Triggered via pull request January 19, 2024 15:02
@alpealpe
synchronize #62
alpe:49_gosec
Status Failure
Total duration 1m 35s
Artifacts

linter.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 3 warnings
lint: pkg/endpoints/endpoints_test.go#L28
Error return value of `g.getBestHost` is not checked (errcheck)
lint: pkg/endpoints/endpoints_test.go#L85
Error return value of `endpoint.getBestHost` is not checked (errcheck)
lint: pkg/deployments/manager.go#L111
string `/models` has 4 occurrences, make it a constant (goconst)
lint: tests/integration/integration_test.go#L146
string `-deploy` has 4 occurrences, make it a constant (goconst)
lint: tests/integration/main_test.go#L135
exitAfterDefer: os.Exit will exit, and `defer testServer.Close()` will not run (gocritic)
lint: pkg/proxy/metrics_test.go#L93
Comment should end in a period (godot)
lint: pkg/proxy/metrics_test.go#L12
File is not `goimports`-ed (goimports)
lint: tests/integration/integration_test.go#L53
G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32 (gosec)
lint: tests/integration/integration_test.go#L113
G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32 (gosec)
lint: pkg/deployments/manager_test.go#L40
unnecessary leading newline (whitespace)
lint: pkg/deployments/manager_test.go#L142
unused-parameter: parameter 'subResource' seems to be unused, consider removing or renaming it as _ (revive)
lint: pkg/deployments/manager_test.go#L151
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint: tests/integration/integration_test.go#L227
unused-parameter: parameter 'ip' seems to be unused, consider removing or renaming it as _ (revive)