Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gh200 support and model #300

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Add gh200 support and model #300

merged 2 commits into from
Nov 2, 2024

Conversation

happytreees
Copy link
Contributor

This PR will add the initial support for GH200 nodes in KubeAI

Copy link
Contributor

@samos123 samos123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Exciting to see GH200 being used.

Let's get this merged after you remove the nodeSelector from values.yaml. I left a few comments.

@@ -20,6 +20,7 @@ modelServers:
default: "vllm/vllm-openai:v0.6.3.post1"
cpu: "substratusai/vllm:v0.6.3.post1-cpu"
google-tpu: "substratusai/vllm:v0.6.3.post1-tpu"
gh200: "drikster80/vllm-gh200-openai:v0.6.3.post1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the plan would be to remove this once the default image works with gh200. I do like how you created an image just for gh200 for now.

charts/kubeai/values.yaml Outdated Show resolved Hide resolved
charts/models/values.yaml Show resolved Hide resolved
@samos123 samos123 merged commit 6082f5c into substratusai:main Nov 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants