Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix category mapping that was breaking rendering #47

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

rccsousa
Copy link
Collaborator

@rccsousa rccsousa commented Oct 4, 2024

Why:

  • archive button wasn't correctly typed and as such was breaking in some situations;
    How:
  • fixed contentType mapping to correct the mentioned errors;

@rccsousa rccsousa marked this pull request as ready for review October 4, 2024 11:32
@rccsousa rccsousa requested a review from davelange October 4, 2024 11:46

export default function ArchiveButton({ collection, color }: ArchiveButtonProps) {
return (
<a href={`/${collection}`} style={{ color: color ? color : 'var(--dark-rock-800)' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be easier to write this as style={{ color: color || var(--dark-rock-800)' }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, will apply from now on. thanks!

@rccsousa rccsousa merged commit c98aa6a into main Oct 4, 2024
1 check passed
@rccsousa rccsousa deleted the rs/fix-archive-button branch October 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants