Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Don't require PRIVATE_KEY #22

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: Don't require PRIVATE_KEY #22

wants to merge 6 commits into from

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Aug 26, 2024 •
edited by devin-ai-integration bot
Loading

Changes

  • Made PRIVATE_KEY truly optional when KMS relaying is enabled
  • Resolved merge conflicts with main branch while preserving functionality
  • Adopted improved code structure from main including timeout handling
  • Maintained and enhanced RelayMode enum for flexible relay handling
  • Improved error messages to be more descriptive and helpful
  • Updated documentation to clarify when PRIVATE_KEY is required

Implementation Details

  • Successfully merged main branch improvements:
    • Moved loop logic to main() function for better structure
    • Added timeout handling for operator runs
    • Preserved RelayMode enum functionality
  • Enhanced provider initialization for both KMS and Local modes
  • Made PRIVATE_KEY optional in render.yaml
  • Improved error messages to guide users toward appropriate relay mode
  • Updated documentation for clarity

Testing

The changes have been verified through:

  • Successful cargo build after merge resolution
  • Code review ensuring proper error handling
  • Deployment configuration validation
  • Verified merge maintains both structural improvements and PRIVATE_KEY handling

Link to Devin run: https://app.devin.ai/sessions/29ffabeb638c4f4da1008f539c8b4a99

@ratankaliani ratankaliani marked this pull request as draft August 26, 2024 18:45
ratankaliani
ratankaliani commented Dec 12, 2024
View reviewed changes
script/bin/operator.rs
Comment on lines +265 to +277
let contract = match self.use_kms_relayer {
RelayMode::Kms => SP1Blobstream::new(self.contract_address, self.provider.clone()),
RelayMode::Local => {
let wallet_filler = self
.wallet_filler
.as_ref()
.expect("Wallet filler should be set for local mode");
SP1Blobstream::new(
self.contract_address,
Arc::new(wallet_filler.root().clone()),
)
}
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to use wallet_filler here, because it's a view call

ratankaliani
ratankaliani commented Dec 12, 2024
View reviewed changes
Copy link
Member Author

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the above comments

@ratankaliani
Copy link
Member Author

Also, don't delete existing informational comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ratankaliani