added must use

succinctlabs · Mar 8, 2024 · d6b6996 · d6b6996
1 parent 9837327
commit d6b6996
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 1 deletion.
diff --git a/plonky2x/core/src/frontend/builder/mod.rs b/plonky2x/core/src/frontend/builder/mod.rs
@@ -358,6 +358,7 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     }
 
     /// Returns 1 if i1 is zero, 0 otherwise as a boolean.
+    #[must_use]
     pub fn is_zero(&mut self, i1: Variable) -> BoolVariable {
         let zero = self.api.zero();
 
@@ -372,6 +373,7 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     }
 
     /// Returns 1 if i1 == i2 and 0 otherwise as a BoolVariable.
+    #[must_use]
     pub fn is_equal<V: CircuitVariable>(&mut self, i1: V, i2: V) -> BoolVariable {
         let mut result = self._true();
         for (t1, t2) in i1.targets().iter().zip(i2.targets().iter()) {

diff --git a/plonky2x/core/src/frontend/hash/common/mod.rs b/plonky2x/core/src/frontend/hash/common/mod.rs
@@ -40,7 +40,7 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     // = a*( 1 - 2*b - 2*c + 4*b*c ) + b + c - 2*b*c
     // = a*( 1 - 2*b -2*c + 4*m ) + b + c - 2*m
     // where m = b*c
-    //
+    #[must_use]
     pub fn xor3(&mut self, a: Variable, b: Variable, c: Variable) -> BoolVariable {
         let m = self.mul(b, c);
         let two_b = self.add(b, b);

diff --git a/plonky2x/core/src/frontend/ops/math.rs b/plonky2x/core/src/frontend/ops/math.rs
@@ -153,11 +153,13 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
 ///
 /// Types implementing this trait can be used within the `builder.lte(lhs, rhs)` method.
 pub trait LessThanOrEqual<L: PlonkParameters<D>, const D: usize, Rhs = Self> {
+    #[must_use]
     fn lte(self, rhs: Rhs, builder: &mut CircuitBuilder<L, D>) -> BoolVariable;
 }
 
 impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     /// The less than or equal to operation (<=).
+    #[must_use]
     pub fn lte<Lhs, Rhs>(&mut self, lhs: Lhs, rhs: Rhs) -> BoolVariable
     where
         Lhs: LessThanOrEqual<L, D, Rhs>,
@@ -166,6 +168,7 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     }
 
     /// The less than operation (<).
+    #[must_use]
     pub fn lt<Lhs, Rhs>(&mut self, lhs: Lhs, rhs: Rhs) -> BoolVariable
     where
         Rhs: LessThanOrEqual<L, D, Lhs>,
@@ -175,6 +178,7 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     }
 
     /// The greater than operation (>).
+    #[must_use]
     pub fn gt<Lhs, Rhs>(&mut self, lhs: Lhs, rhs: Rhs) -> BoolVariable
     where
         Lhs: LessThanOrEqual<L, D, Rhs>,
@@ -183,6 +187,7 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     }
 
     /// The greater than or equal to operation (>=).
+    #[must_use]
     pub fn gte<Lhs, Rhs>(&mut self, lhs: Lhs, rhs: Rhs) -> BoolVariable
     where
         Rhs: LessThanOrEqual<L, D, Lhs>,
@@ -191,6 +196,7 @@ impl<L: PlonkParameters<D>, const D: usize> CircuitBuilder<L, D> {
     }
 
     /// The within range operation (lhs <= variable < rhs).
+    #[must_use]
     pub fn within_range<V>(&mut self, variable: V, lhs: V, rhs: V) -> BoolVariable
     where
         V: LessThanOrEqual<L, D, V> + Sub<L, D, V, Output = V> + One<L, D> + Clone,

diff --git a/plonky2x/core/src/frontend/uint/uint32.rs b/plonky2x/core/src/frontend/uint/uint32.rs
@@ -127,6 +127,7 @@ impl From<U32Target> for U32Variable {
 }
 
 impl<L: PlonkParameters<D>, const D: usize> LessThanOrEqual<L, D> for U32Variable {
+    #[must_use]
     fn lte(self, rhs: Self, builder: &mut CircuitBuilder<L, D>) -> BoolVariable {
         list_lte_circuit(&mut builder.api, self.targets(), rhs.targets(), 32).into()
     }

diff --git a/plonky2x/core/src/frontend/uint/uint32_n.rs b/plonky2x/core/src/frontend/uint/uint32_n.rs
@@ -303,6 +303,7 @@ macro_rules! make_uint32_n {
         }
 
         impl<L: PlonkParameters<D>, const D: usize> LessThanOrEqual<L, D> for $a {
+            #[must_use]
             fn lte(self, rhs: Self, builder: &mut CircuitBuilder<L, D>) -> BoolVariable {
                 let mut lte_acc = builder.constant::<BoolVariable>(false);
                 let mut equal_so_far = builder.constant::<BoolVariable>(true);