refactor: Remove cgat[core] imports and dependencies #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-rse
force-pushed
the
ns-rse/remove-unused-imports
branch
2 times, most recently
from
bf4b1d0 to
b3b8800
Compare
Removing unused imports and switching to `argparse.ArgumentParse` in `all_introns_counts_and_info.py` means we can now remove the import and dependency on `cgat` and `cgatcore`. At the same time update `tests.yaml`, removing Python 3.9 from the test matrix and ensure `pytest-regtest` is included in the optional test dependencies. We also remove Windows from the OS test matrix as `pySAM` doesn't provide wheels and building that dependency from source is failing.
ns-rse
force-pushed
the
ns-rse/remove-unused-imports
branch
from
b3b8800 to
0a0a910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unused imports and switching to
argparse.ArgumentParseinall_introns_counts_and_info.pymeans we can nowremove the import and dependency on
cgatandcgatcore.At the same time update
tests.yaml, removing Python 3.9 from the test matrix and ensurepytest-regtestis included in the optional test dependencies.Should have included this in the previous PR but wasn't paying attention.
Regression tests pass (and should run on CI 🤞 ).
Closes #63