ci/style: Trying to ignore files that won't be type checked #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution was to use `# mypy: ignore-errors` on individual files. Adds the option `warn_unused_ignores = true` so that as individual type hints get corrected we can remove the specific ignore statements that were added.
ns-rse
force-pushed
the
ns-rse/mypy-config
branch
from
7bd311c to
ffa951a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried various combinations to exclude based on the official
documentation as well as adding an explicit
# type: ignoreto the top of the files that should be ignored butmypyis still trying to check these for some reason. 🤷Ultimately the solution was to use
# mypy: ignore-exceptionsat the head of the file.Have added some additional configuration options to
mypyconfiguration inpyproject.tomland.pre-commit-config.yamlanyway.